It is worth a visit. The Shanghai Museum has a nice permanent exhibition and also the building itself is rather interesting, being in the form of a kettle. Don’t limit yourself though to just this museum. Shanghai has many other cool things to do. Not only are there several museums in Shanghai but also other attraction like the big TV Tower, the Bund etc.