The things that hometownzero discribes are pretty much what I would say are the typical tourist things. Arthur’s Seat, and Holyrood park in general I would recommend, particuarly if you get a good day weatherwise. Getting to the top shouldn’t take too long, but you might want to take your time about it.

Edinburgh Castle, I would agree, is an overpriced tourist trap. It’s £10 an adult, I think. If you can get there, go to Craigmillar Castle instead. It’s a bit out of the way, but I always enjoy it when I’m there, and it’s so quiet compared to ‘up town’. Although, for shopping, I would recommend Princes street and the Royal Mile.

Leith itself has had a great revival in the past few years. In terms of eating, just head down to the Shore and see what takes your fancy, there is a lot to chose from. Britannia (agian, bit of a toursit trap) is at Ocean Terminal, a shopping mall basically, but a very nice one, which also has a cinema in it, if you want a movie.

There’s a great range of accomodation in Edinburgh, the greatest outside London, I believe. For truly upmarket, then it would have to be one of the places in town, Balmoral, Caledonian, Carlton or Scotsman. Otherwise there are lot of B&B’s, particularly in East Hermitage Place which faces onto Leith Links (my dad lives just behind them), and also Pilrig Street which is up Leith Walk a bit. You shouldn’t have too much trouble finding something in April.

And for travelling I recommend Lothian Buses (the red ones), as they are fairly reliable and particuarly good for going into town, which is where you could catch one of the tour bues which will show the sights. Otherwise walk, as Edinburgh is pretty easy to get around on foot.

Well, I hope some of this helps, and have a great time!